Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SessionKeys Module #17

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add support for SessionKeys Module #17

merged 4 commits into from
Jul 10, 2024

Conversation

kaushalrajbacancy
Copy link
Contributor

Description

  • Added SessionKeyValidator module for ERC20SessionKeyValidator.
  • Added enableSessionKey, rotateSessionKey, disableSessionKey, and getAssociatedSessionKeys functions to SessionKeyValidator.

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Executed userOps for enable, rotate and disable sessionKeys.

ch4r10t33r
ch4r10t33r approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xSulpiride
0xSulpiride approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Could you also create a userop using session keys or is that a part of another ticket?
cc: @ch4r10t33r

@ch4r10t33r
Copy link
Member

LGTM.

Could you also create a userop using session keys or is that a part of another ticket? cc: @ch4r10t33r

That's part of a separate ticket and there will be a new PR for that.

ch4r10t33r
ch4r10t33r approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaushalrajbacancy kaushalrajbacancy merged commit ff45c19 into master Jul 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

@vignesha22 vignesha22 Awaiting requested review from vignesha22

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalrajbacancy @ch4r10t33r @0xSulpiride